Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding job submit ENVIRONMENT and minor improvement to runWorkflow #3040

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented Nov 5, 2020

adding job submit ENVIRONMENT and minor improvement to runWorkflow

antgonza and others added 2 commits September 16, 2020 16:57
* inject study_type in EBI and improvements to current automatic processing pipeline (qiita-spots#3023)

* inject study_type in ebi and improvements to current automatic proecssing pipeline

* addressing @ElDeveloper comments

* some general fixes/additions for next release (qiita-spots#3026)

* some general fixes/additions for next release

* adding test for not None job.release_validator_job

* fix qiita-spots#2839

* fix qiita-spots#2868 (qiita-spots#3028)

* fix qiita-spots#2868

* 2nd round

* fix errors

* more changes

* fix errors

* fix ProcessingJobTest

* fix PY_PATCH

* add missing TRN.add

* encapsulated_query -> perform_as_transaction

* fix qiita-spots#3022 (qiita-spots#3030)

* fix qiita-spots#3022

* adding tests

* fix qiita-spots#2320 (qiita-spots#3031)

* fix qiita-spots#2320

* adding prints to debug

* children -> 1

* APIArtifactHandlerTest -> APIArtifactHandlerTests

* configure_biom

* qdb.util.activate_or_update_plugins

* improving code

* almost there

* add values.template

* fix filepaths

* filepaths -> files

* fixing errors

* add prep.artifact insertion

* addressing @ElDeveloper comments

* fix artifact_definition active command

* != -> ==

* Added three tutorial sections to the Qiita documentation (qiita-spots#3032)

* Added three tutorial sections to the Qiita documentation: 'Retrieving Public Data for Own Analysis' and 'Processing public data retrieved with redbiom' to the redbiom tab, and 'Statistical Analysis to Justify Clinical Trial Sample Size Tutorial' to the analyzing samples tab.

* Update redbiom.rst

* Update redbiom.rst

* Update redbiom.rst

* Further updates to redbiom.rst and the Stats tutorial.

* update redbiom.rst

* Finished proof-reading

* Placed all three tutorials/sections together under Introduction to the download and analysis of public Qiita data

* added a new introduction, with links to the three sections

* Added figures to stats tutorial and contexts explanation

* Added figures to stats tutorial and contexts explanation

* Apply suggestions from code review [skip ci]

Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>

Co-authored-by: Antonio Gonzalez <[email protected]>
Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>

* 092020 (qiita-spots#3033)

* 092020

* connect artifact with job

* rm INSERT qiita.artifact_processing_job

* Apply suggestions from code review [skip ci]

Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>

Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>

Co-authored-by: Daniel McDonald <[email protected]>
Co-authored-by: Mirte Kuijpers <[email protected]>
Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>
@antgonza antgonza requested a review from ElDeveloper November 5, 2020 14:03
@codecov-io
Copy link

Codecov Report

Merging #3040 into master will increase coverage by 0.04%.
The diff coverage is 88.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3040      +/-   ##
==========================================
+ Coverage   94.98%   95.02%   +0.04%     
==========================================
  Files          74       74              
  Lines       14153    14315     +162     
==========================================
+ Hits        13443    13603     +160     
- Misses        710      712       +2     
Impacted Files Coverage Δ
qiita_db/archive.py 100.00% <ø> (ø)
qiita_db/base.py 92.30% <ø> (-0.15%) ⬇️
qiita_db/download_link.py 33.33% <0.00%> (+3.60%) ⬆️
qiita_db/exceptions.py 95.91% <ø> (-0.09%) ⬇️
qiita_db/investigation.py 61.90% <ø> (-1.74%) ⬇️
...adata_template/test/test_base_metadata_template.py 98.18% <ø> (ø)
qiita_db/metadata_template/util.py 90.16% <ø> (-0.08%) ⬇️
qiita_db/reference.py 96.55% <ø> (-0.06%) ⬇️
qiita_db/environment_manager.py 42.99% <50.00%> (-0.82%) ⬇️
qiita_db/processing_job.py 73.89% <73.41%> (+1.86%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7abc5...6e91134. Read the comment docs.

@antgonza antgonza changed the base branch from master to dev November 5, 2020 22:43
@antgonza antgonza changed the base branch from dev to master November 5, 2020 22:43
@antgonza antgonza changed the base branch from master to dev November 5, 2020 22:44
Copy link
Member

@ElDeveloper ElDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question/comment.

qiita_db/processing_job.py Show resolved Hide resolved
@ElDeveloper ElDeveloper merged commit e4ad2d2 into qiita-spots:dev Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants